Skip adding directories to RECORD with wheel tags
#559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 72.29% 72.35% +0.05%
==========================================
Files 13 13
Lines 1083 1085 +2
==========================================
+ Hits 783 785 +2
Misses 300 300
☔ View full report in Codecov by Sentry. |
|
This only removed listing the directories, not the contents of directories, so looks good to me. Personally, I recommend splitting unrelated cleanup & fixes/features if possible, makes review easier. But IMO the changes look good. |
mwtoews
force-pushed
the
fix-record-for-tags
branch
from
c5d0a21
to
c85a058
Compare
I normally do that too, so it's split to #561 |
|
Please add a note to the changelog ( |
mwtoews
force-pushed
the
fix-record-for-tags
branch
from
c85a058
to
36933f0
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #558
Tests are not included yet, but advice would be welcome. The example with tests/test_tagopt.py would probably needed to be modified to add some dummy data files in a subdir.Some testing has been modified, but advice on more is welcome.This PR also removes (now) unnecessary use of OrderedDict, and tidies a str concat.