Add icon for change log etc project URL #7882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @scop! |
This was referenced May 5, 2020
scop
added a commit
to scop/django-stubs
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882
This was referenced May 5, 2020
scop
added a commit
to scop/huawei-lte-api
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882 (comment)
scop
added a commit
to scop/huawei-lte-api
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882 (comment)
This was referenced May 5, 2020
scop
added a commit
to scop/mypy
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882 (comment)
cooperlees
pushed a commit
to PyCQA/flake8-bugbear
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882 (comment)
scop
added a commit
to scop/url-normalize
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882 (comment)
scop
added a commit
to scop/python-rflink
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882 (comment)
This was referenced May 5, 2020
sobolevn
pushed a commit
to typeddjango/django-stubs
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882
This was referenced May 5, 2020
Nurdok
pushed a commit
to PyCQA/pydocstyle
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882 (comment)
atodorov
pushed a commit
to pylint-dev/pylint-django
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882 (comment)
ericwb
pushed a commit
to PyCQA/bandit
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882
aequitas
pushed a commit
to aequitas/python-rflink
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882 (comment)
scop
added a commit
to scop/pre-commit
that referenced
this pull request
May 5, 2020
Background info at pypi/warehouse#7882 (comment)
This was referenced May 5, 2020
PCManticore
pushed a commit
to pylint-dev/pylint
that referenced
this pull request
May 6, 2020
Background info at pypi/warehouse#7882
This was referenced May 8, 2020
webknjaz
reviewed
May 11, 2020
| @@ -21,6 +21,8 @@ | |||
| {% set icon = "fas fa-cloud-download-alt" %} | |||
| {% elif name|lower in ["home", "homepage", "home page"] %} | |||
| {% set icon = "fas fa-home" %} | |||
| {% elif name|lower in ["changelog", "change log", "changes", "release notes", "news", "what's new"] %} | |||
There was a problem hiding this comment.
@scop I often use category prefixes for links. See https://pypi.org/project/aiohttp/. So it'd be better to match if any of these are in the name and not just match exactly. In this case, I'd rather use Docs: changelog to follow the same style as Docs: RTD.
There was a problem hiding this comment.
I'm sure the warehouse maintainers would consider such a PR :)
|
BTW, are these recognised names documented anywhere? Or even just one preferred form for each category? As a project maintainer, it would be good to be able to see at a glance what names I should use, because you're never going to cover every possibility. |
|
@takluyver Not yet: #5947 |
kislyuk
pushed a commit
to kislyuk/argcomplete
that referenced
this pull request
Sep 27, 2020
* Add change log project URL Background info at pypi/warehouse#7882 (comment)
hauntsaninja
pushed a commit
to python/mypy
that referenced
this pull request
Sep 27, 2020
Background info at pypi/warehouse#7882 (comment)
mikespallino
pushed a commit
to mikespallino/bandit
that referenced
this pull request
Aug 25, 2021
Background info at pypi/warehouse#7882
mikespallino
pushed a commit
to mikespallino/bandit
that referenced
this pull request
Jan 7, 2022
Background info at pypi/warehouse#7882
busgaidw2
added a commit
to busgaidw2/flake8-bugbear
that referenced
this pull request
Aug 6, 2024
Background info at pypi/warehouse#7882 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting to package change logs, release notes or the like is currently a manual task, as links to them are not defined just about anywhere except perhapse in description prose. I think it would be good to promote adding them.
For example, when I see a new release from a project RSS feed being made, I go to PyPI and... start manually sifting through pages here and there to find what's changed in the release. Would be very nice to have a direct link in project links for that.
Although this is beyond PyPI, adding a recognizable specific icon could be a step towards that direction.