-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix net folder #2363
fix net folder #2363
Conversation
needs to be addressed:
|
since there are many places in which the revit version is checked, we could move the version check to try:
NETCORE = int(_get_revit_version()) >= 2025
except Exception: # maybe we should change the exception thrown by the None check
NETCORE = False # not sure about this, should we default to True? leave it None? Or change the function to directly return True or False. Then we can use from pyrevit.compat import NETCORE
if NETCORE: # or if not NETCORE:
# do the thing whenewer there's a version check. The next step would be to directly inject the revit version (or the current dotnet runtime) value via ironpython/pythonnet builtins, and point the |
One note: since the "Copy views" is a pushbutton, it should always receive an |
Given the other issues with hooks, it's better to solve this on the C# side and ensure that |
@sanzoghenzo you are on fire |
I didn't test the modification at all 😅 I'll try them later to see if I broke something in netfx. If you have some time, please let me know if it works on revit 2025 |
@sanzoghenzo
|
That's strange, I didn't touch any .cs/.dll files, those errors comes before the python scripts I edited gets loaded (but I may be wrong). I'll check this later |
Just checked the latest installer pre-commit of this draft PR and all good (except a typo in the de_de translation of the reload button, but nothing important) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for @eirannejad to shed some light about the __revit__
builtin polymorphism, I think this should cover most of the cases.
It may be a good time to remove all references of __revit__
in the notion site and use HOST_APP.uiapp
(or the other properties) instead
~~Latest WIP does not isntall CLI properly 😸 ~~ |
Wait, I'm not sure I follow you, this branch doesn't have an associated CI job with installers to try... what are you testing? 🤣 |
I was testing the latest wip to see if the bug was introduced by your changes (attaching this PR to Revit) or by previous changes (installing latest wip) |
I've merged the current develop branch to this PR, so you can use the latest WIP installer for this. As you can see from the "files changed" section here, I only touched .py files, so the pyrevitloader.dll is not affected at all. The first message is thrown because it cannot find the The python lib are there, and listed as embedded resources in both loader and runner (which I believe is a waste of space, but I still didn't learn much about those projects). |
I realize now that attaching engines/loaders from a clone means using all of its dlls, so it may be that some binaries are missing - but then again - i didn't touch them, so it should be happening regardless of this PR! Try to run a Meanwhile, I enabled the PyrevitDevHooks extension (I previously tell you the wrong one), and a plethora of errors welcomed me. I solve what I could, but I also got this from the VB.NET and C# hooks for the activation of a view : This could be an old bug, who knows... |
my dev environment is not properly setup to run this. |
@sanzoghenzo I just launched the CI on this PR branch to be able to test it properly |
You remind me that I still need to create the documentation on how to setup the dev environment 😉 I see that you find the way to run the CI manually on this branch, so I don't have to tell you how to do it 😅 |
I think we could merge this one and get going from there. |
what do you think @sanzoghenzo @dosymep |
You have my blessing! 😉 |
📦 New work-in-progress (wip) builds are available for 5.0.0.24235+1159-wip |
📦 New work-in-progress (wip) builds are available for 5.0.0.24236+2228-wip |
📦 New work-in-progress (wip) builds are available for 5.0.0.24240+2307-wip |
📦 New work-in-progress (wip) builds are available for 5.0.0.24242+0910-wip |
📦 New work-in-progress (wip) builds are available for 5.0.0.24246+1410-wip |
📦 New work-in-progress (wip) builds are available for 5.0.0.24253+1920-wip |
📦 New work-in-progress (wip) builds are available for 5.0.0.24254+1158-wip |
📦 New work-in-progress (wip) builds are available for 5.0.0.24254+1351-wip |
📦 New work-in-progress (wip) builds are available for 5.0.0.24261+0647-wip |
📦 New work-in-progress (wip) builds are available for 5.0.0.24281+2116-wip |
#2351 (comment)