IronPython 3 Compatibility and Update for xlrd & xlsxwriter #2422
+3,137
−1,192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces:
Compatible
variable for handling IronPython 2/3, Cpython, netcore, netframework. trgiangv@cf51642Updated
xlrd
andxlsxwriter
Library:Fix build
pyrevitLabs.pyRevit.Runtime
only target IronPython 2.7pyRevit/dev/pyRevitLabs.PyRevit.Runtime/Directory.Build.targets
Line 24 in 86697ad
Additional Notes:
What challenges are we facing if we set
IronPython3
as the default engine?