typeLookup: guard on tp_version_tag instead of mro #966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This if WIP but before spending more time on it I would like to get feedback on it.
This removes the guarding
Box::getattr
adds for types which have theHAVE_VERSION_TAG
set (aka. all types except capi extensions types which are not part of pyston)instead it guards on the
tp_version_tag
.There is currently a problem that the version tags are only 32bit and can overflow. So in case they overflow we need some mechanism to invalidate all ICs....
Perf change of the last commit: