Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrizing event_loop_policy parametrizes all tests #796

Open
aceg1k opened this issue Mar 6, 2024 · 1 comment
Open

Parametrizing event_loop_policy parametrizes all tests #796

aceg1k opened this issue Mar 6, 2024 · 1 comment
Labels
Milestone

Comments

@aceg1k
Copy link

aceg1k commented Mar 6, 2024

Contrary to the statements in the documentation (here and here), the fixture is not only applied to all pytest-asyncio tests, but also applied to all other tests.

import asyncio
import pytest
import uvloop

@pytest.fixture(
    scope="session",
    params=(asyncio.get_event_loop_policy(), uvloop.EventLoopPolicy()),
    ids=("asyncio", "uvloop"),
)
def event_loop_policy(request):
    return request.param

@pytest.mark.asyncio
async def test_async():
    pass

def test_sync():
    pass

Output:

plugins: asyncio-0.23.5
asyncio: mode=Mode.STRICT
collected 4 items                                                                                                       

test_event_loop_policy.py::test_async[asyncio] PASSED                                                             [ 25%]
test_event_loop_policy.py::test_sync[asyncio] PASSED                                                              [ 50%]
test_event_loop_policy.py::test_async[uvloop] PASSED                                                              [ 75%]
test_event_loop_policy.py::test_sync[uvloop] PASSED                                                               [100%]
@seifertm seifertm added the bug label Jul 10, 2024
@seifertm seifertm added this to the v1.0 milestone Jul 10, 2024
@seifertm
Copy link
Contributor

Thanks for the report and the reproducer!

The event loop policy fixture is defined as an autouse fixture. I don't exactly recall why, but I think the reason is that it's now used by the deprecated event_loop fixture and had to be marked as autouse for backwards compatibility.

It's obviously a bug that this also parametrizes all sync tests and needs to be addressed.

However, I don't expect this issue to be fixed before v1.0 when the legacy event_loop fixture is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants