Fix: timezone info occasionally removed from cron job execution time #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 11 11
Lines 1063 1063
Branches 200 200
=======================================
Hits 1046 1046
Misses 8 8
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
|
Tests has been fixed in #382, so don't worry about the pipelines failing for some Python versions. |
JonasKs
approved these changes
Dec 18, 2022
rossmacarthur
pushed a commit
to hunchdata/arq
that referenced
this pull request
Sep 19, 2023
iamlikeme
force-pushed
the
fix-next-cron
branch
2 times, most recently
from
55d9d5b
to
b50c1dc
Compare
iamlikeme
force-pushed
the
fix-next-cron
branch
from
b50c1dc
to
4a0e151
Compare
|
Ready for merging 🙏 |
nierob
approved these changes
Dec 1, 2023
|
thanks so much, sorry for the long delay. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where timezone information was occasionally removed from execution time of cron jobs. The bug affected cron jobs which used the month-rule and when month was incremented due to that rule.
Since #354 all cron calculations are done on timezone aware datetimes. However, the tests for
next_cronfunction were not updated to include timezone in all test cases, which is how the bug slipped through. The tests are updated now to always use timezone.Fixes: #380