Improves after_job_end hook #409
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
- Coverage 98.40% 98.31% -0.09%
==========================================
Files 11 11
Lines 1063 1071 +8
Branches 200 201 +1
==========================================
+ Hits 1046 1053 +7
Misses 8 8
- Partials 9 10 +1
Continue to review full report in Codecov by Sentry.
|
|
@AngellusMortis hi there 👋 I am taking advantage of your deeper knowledge regarding this hook. question: without this PR the hook If that is the case, would there be a work around using other hooks ? Thanks in advance |
| async def job_failed(exc: BaseException, ref: Optional[str] = None) -> None: | ||
| ref = ref or f'{job_id}:{function_name}' |
There was a problem hiding this comment.
| async def job_failed(exc: BaseException, ref: Optional[str] = None) -> None: | |
| ref = ref or f'{job_id}:{function_name}' | |
| async def job_failed(exc: BaseException, ref: str = f'{job_id}:{function_name}') -> None: |
| @@ -701,6 +687,12 @@ async def finish_job( | |||
| tr.delete(*delete_keys) # type: ignore[unused-coroutine] | |||
| await tr.execute() | |||
|
|
|||
| async def _after_job_end(self, ctx: Dict[Any, Any], job_result: Optional[JobResult]) -> None: | |||
| queue_name: str, | ||
| *, | ||
| serializer: Optional[Serializer] = None, | ||
| ) -> Tuple[JobResult, Optional[bytes]]: |
There was a problem hiding this comment.
please add a docstring explaining what this does.
|
I no longer care. |
Since
finish_jobcan fail, I adjusted theafter_job_endhook to always receive a copy of the theJobResultthat would get written into redis.I also updated all of the other places that recorded a failing job to call
after_job_endas well and added aasyncio.shieldtoafter_job_endas it is a great way to do something with the job result (like generate metrics for New Relic/Prometheus/etc.).