Uses testcontainers to provide a redis instance for the unit tests
#470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't assume that a dev would want the unit tests to connect to the locally running redis at `localhost:6379`, so I'd rather shift that to assuming that the user has a Docker-compatible system available. This makes the test suite easier to reason about and lets us control the redis version with more precision, and it makes the initial startup experience easier for new devs.
chrisguidry
commented
Jul 18, 2024
samuelcolvin
approved these changes
Jul 23, 2024
|
LGTM, merge if you're happy. |
JonasKs
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't assume that a dev would want the unit tests to connect to the locally
running redis at
localhost:6379, so I'd rather shift that to assuming that theuser has a Docker-compatible system available. This makes the test suite easier
to reason about and lets us control the redis version with more precision, and
it makes the initial startup experience easier for new devs.