Skip to content

Commit

Permalink
Fix more links
Browse files Browse the repository at this point in the history
  • Loading branch information
hynek committed Dec 28, 2021
1 parent fcfb5a6 commit d528dd4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ Changes

See the `new docs on comparison <https://www.attrs.org/en/stable/comparison.html>`_ for more details.
`#787 <https:/python-attrs/attrs/issues/787>`_
- Added **provisional** support for static typing in ``pyright`` via the `dataclass_transforms specification <https:/microsoft/pyright/blob/master/specs/dataclass_transforms.md>`_.
- Added **provisional** support for static typing in ``pyright`` via the `dataclass_transforms specification <https:/microsoft/pyright/blob/main/specs/dataclass_transforms.md>`_.
Both the ``pyright`` specification and ``attrs`` implementation may change in future versions of both projects.

Your constructive feedback is welcome in both `attrs#795 <https:/python-attrs/attrs/issues/795>`_ and `pyright#1782 <https:/microsoft/pyright/discussions/1782>`_.
Expand Down
4 changes: 4 additions & 0 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@
"""

linkcheck_ignore = [
# We run into GitHub's rate limits.
r"https:/.*/(issues|pull)/\d+",
# It never finds the anchor even though it's there.
"https:/microsoft/pyright/blob/main/specs/"
"dataclass_transforms.md#attrs",
]

# In nitpick mode (-n), still ignore any of the following "broken" references
Expand Down
2 changes: 1 addition & 1 deletion docs/types.rst
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Given the following definition, ``pyright`` will generate static type signatures

- The ``attr.frozen`` decorator is not typed with frozen attributes, which are properly typed via ``attr.define(frozen=True)``.

A `full list <https:/microsoft/pyright/blob/main/specs/dataclass_transforms.md#Attrs>`_ of limitations and incompatibilities can be found in pyright's repository.
A `full list <https:/microsoft/pyright/blob/main/specs/dataclass_transforms.md#attrs>`_ of limitations and incompatibilities can be found in pyright's repository.

Your constructive feedback is welcome in both `attrs#795 <https:/python-attrs/attrs/issues/795>`_ and `pyright#1782 <https:/microsoft/pyright/discussions/1782>`_.
Generally speaking, the decision on improving ``attrs`` support in pyright is entirely Microsoft's prerogative though.
Expand Down

0 comments on commit d528dd4

Please sign in to comment.