-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to typing.dataclass_transform() #1157
Comments
Don't see why not, feel free to proceed with a PR. I believe our use of |
Yes, IIRC that feature was incubated in pyright and then proposed&accepted as a PEP. Will send a PR soon. |
superbobry
added a commit
to superbobry/attrs
that referenced
this issue
Jun 26, 2023
superbobry
added a commit
to superbobry/attrs
that referenced
this issue
Jun 28, 2023
superbobry
added a commit
to superbobry/attrs
that referenced
this issue
Jun 29, 2023
superbobry
added a commit
to superbobry/attrs
that referenced
this issue
Jun 29, 2023
fixed by #1158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
attrs
type stubs seem to use a non-standard pyright extension instead of the API described in PEP-681:attrs/src/attr/__init__.pyi
Lines 106 to 121 in 4461e2c
This makes it difficult for other type checkers and similar tools to consume these type stubs without mirroring the pyright extension.
Would you accept a PR replacing all usages of
__dataclass_transform__()
withtyping.dataclass_transform()
? We can usetyping_extensions
to getdataclass_transform()
on Python < 3.11.The text was updated successfully, but these errors were encountered: