added first doc stub #506
Merged
added first doc stub #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the first steps would be:
You may want to give another look to our contributing help file since it has a bunch of valuable information that will save you a lot of time! |
chobeat
force-pushed
the
feat/class_docstrings
branch
from
17d572e
to
4533269
Compare
|
@hynek now the test passes but it's trivial stuff so far. From the other thread on the issue we left open the discussion on how to proceed from here. |
chobeat
force-pushed
the
feat/class_docstrings
branch
from
55b886a
to
633107f
Compare
|
I've added the newsfragment and I've addressed most of the points. When you answer in the open conversations I can proceed. |
|
Sorry I dropped the ball on this, could you resolve the conflicts please? |
chobeat
force-pushed
the
feat/class_docstrings
branch
from
217f183
to
b4326af
Compare
hynek
approved these changes
Mar 6, 2020
|
Thanks and sorry for the delays! |
|
Is this the solution to #492? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.