Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels from sdist in CI #18

Closed

Conversation

webknjaz
Copy link

This patch integrates re-actors/checkout-python-sdist in place of actions/checkout.
It allows making sure that the sdists are downstream-friendly by not relying on Git
checkouts for making wheels. This is how pip makes wheels when there's no matching
built distributions.

This patch integrates `re-actors/checkout-python-sdist` in place of
`actions/checkout`.
@nitzmahone
Copy link
Member

Implemented by #79

@nitzmahone nitzmahone closed this May 23, 2024
@webknjaz
Copy link
Author

@nitzmahone partially, right?

@nitzmahone
Copy link
Member

@webknjaz All the wheels are being built from the same-run sdist artifact now, unless I missed something? The only checkouts now are the sdist job itself and the matrix generator jobs, since those need access to the (currently) in-repo custom action. Once that's settled down, I might externalize it (esp since I'm using it in PyYAML too), but want to see how it holds up in the real world for awhile.

@webknjaz
Copy link
Author

@nitzmahone so the thing I noticed is that you unpack the sdist manually. However, cibuildwheel can do that for you, in a manner that is cleaner and closer to the real-world builds from sdist in the build frontends like pip. I think that's something to implement still.

@webknjaz
Copy link
Author

@nitzmahone this is what I had in mind: #82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants