Py3k libraries path fix (issue #41) #60
Conversation
| if platform.processor() == "x86_64": | ||
| platform_ = platform.processor() | ||
| if not platform_: | ||
| platform_ = platform.architecture()[0] |
There was a problem hiding this comment.
Why not just do this always?
There was a problem hiding this comment.
The python docs warn of use of platform.architecture()[0] being unreliable in some cases and that sys.maxsize is better. Something like:
arch_bits = int(math.log(sys.maxsize, 2) + 1)
might be a more cross platform way of getting the architecture's bit size.
HTH
There was a problem hiding this comment.
This is not so cross-platform part of the code, it is Linux-only. Why I'm leaving platform.processor() requests is because most of the people are not facing this issue (or I am wrong and we have many people discussing my bugreport?), so I left default implementation and when it fails - I'm trying different approach.
There was a problem hiding this comment.
or I am wrong and we have many people discussing my bugreport
Sorry, no - I was doing a bit of github surfing and saw this. I don't have any specific perspective on this, I just spotted it and thought I would comment 😄 - on reflection I don't think my comments are that useful - sorry for the noise.
Cheers,
Py3k libraries path fix (issue #41)
|
Thanks |
Mergify test - Add all successful report jobs for GHA
Updated libtiff to 4.0.8
No description provided.