Added saving LA images as PDFs #7299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homm
reviewed
Jul 22, 2023
| @@ -490,6 +490,8 @@ j2k_encode_entry(Imaging im, ImagingCodecState state) { | |||
|
|
|||
| if (strcmp(im->mode, "RGBA") == 0) { | |||
| image->comps[3].alpha = 1; | |||
| } else if (strcmp(im->mode, "LA") == 0) { | |||
There was a problem hiding this comment.
Does it mean there was no LA support for JPEG2K at all? Do we need better testing for this case, which is not related to pdf?
There was a problem hiding this comment.
Without this change, saving an LA image as JPEG2K and visually inspecting it, shows a black rather than transparency. This fixes that. However, opening the saved image afterwards and running getpixel() gives (0, 0) either way.
When Pillow reads a JPEG2K image, it only checks the "number of components" to see if it is LA.
homm
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7293
This is similar to #6925, except for LA instead of RGBA, and so uses
Pillow/src/PIL/PdfImagePlugin.py
Lines 160 to 161 in ea0abb9
instead of
Pillow/src/PIL/PdfImagePlugin.py
Lines 174 to 175 in ea0abb9