-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added trusted repository option #80
Added trusted repository option #80
Conversation
…, only similar to it
@abn Is there a reason this is not getting merged? |
Why is the option added to the schema of At least, I think this deserves more discussion before merging (otherwise it might have to be changed again, causing yet more breaking changes regarding certificates, like when |
I don't agree that this option defines how to validate the TLS connection but rather if.
While I can see why this might be an interesting feature, the main usage of this option is in scenarios where you use a self-hosted private repository and can't be bothered setting up certificates (usually in some sort of enterprise environment).
I don't agree that this is a breaking change: this option field is optional, and could default to the current behavior. |
@maayanbar13 sorry if I wasn't clear, I don't mean to define it in the certificate file, but in a config option like It is also makes more sense to me there than in pyproject.toml for privately hosted repos, because it is something that is related to the repository, not the project. Obviously, having both options available would be fine too. |
…into option-trusted-repository
Sure, that makes sense. That feature is unrelated to the |
Is there any reason this PR is still pending after all this time? |
@maayanbar13 can you please solve merge conflicts and push again ? |
@therewillbeblood Sure :) |
@abn it seems you are assigned as a reviewer, would you have an ETA to share to us when you could do the review ? |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
First off; apologies for not getting to this earlier. Second, I think (along the lines of what @absassi was suggesting) that this should be a poetry level option for repository that ends up being configured as For the above reason, I am closing this issue. But will review any downstream PR for the new |
Upstream fix for python-poetry/poetry#2912.
Resolves upstream issue python-poetry/poetry#1556.
Pull Request Check List
Updated documentation for changed code.Added tests for changed code.Both not applicable, docs and tests are added in upstream PR.