Make pre-commit hook regex more precise #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In regular expressions, the dot `.` is a metachar that matches every char. To match the literal dot it must be escaped `\.`. Without the escape, that regex would match unintended filenames, such as `poetry-lock`, `poetry_lock`, `poetryblock`, `poetryclock` and other variations.
radoering
reviewed
May 18, 2024
Now using the same regex as the one used in https:/python-poetry/poetry/blob/25b3f6c2f4347286eb31b00f6e39126e57eac5a2/.pre-commit-hooks.yaml#L23 Co-authored-by: Randy Döring <[email protected]>
|
radoering
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regular expressions, the dot
.is a metachar that matches every char. To match the literal dot it must be escaped\..Without the escape, that regex would match unintended filenames, such as
poetry-lock,poetry_lock,poetryblock,poetryclockand other variations.