Implement lsp_rename() #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieryan
commented
Oct 5, 2022
pylsp_rope/plugin.py
Outdated
| new_name, | ||
| ) -> typing.WorkspaceEdit: | ||
| # rope_config = config.settings(document_path=document.path).get("rope", {}) | ||
| # project = workspace._rope_project_builder(rope_config) |
There was a problem hiding this comment.
Remove commented out code
lieryan
force-pushed
the
lieryan-implement-rename
branch
4 times, most recently
from
34f901a
to
4da44a2
Compare
lieryan
commented
Mar 11, 2024
lieryan
force-pushed
the
lieryan-implement-rename
branch
from
4da44a2
to
d1825aa
Compare
Rename using pylsp-rope can be enabled with workspace config key `pylsp.plugins.pylsp_rope.rename`. Note that this differs from the config key `pylsp.plugins.rope_rename.enabled` that is used for the builtin python-lsp-server rope implementation. To avoid confusion, avoid enabling more than one python-lsp-server rename plugin.
It seems like there's strange desynchronisation issues between client buffer state and rope's if we reused the project. We'll eventually want to fix this, but for now, this works the least awful.
lieryan
force-pushed
the
lieryan-implement-rename
branch
from
938fbd1
to
8736268
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 98.48% 98.58% +0.09%
==========================================
Files 21 22 +1
Lines 923 988 +65
==========================================
+ Hits 909 974 +65
Misses 14 14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14