Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClickForLatLng() is not implemented even if PR #1530 #1616

Closed
eabase opened this issue Aug 25, 2022 · 3 comments · Fixed by #1627
Closed

ClickForLatLng() is not implemented even if PR #1530 #1616

eabase opened this issue Aug 25, 2022 · 3 comments · Fixed by #1627
Labels
bug An issue describing unexpected or malicious behaviour

Comments

@eabase
Copy link

eabase commented Aug 25, 2022

Describe the bug
The folium.ClickForLatLng() functionality seem to be missing.

AttributeError: module 'folium' has no attribute 'ClickForLatLng'. Did you mean: 'ClickForMarker'?

To Reproduce

# ...
m = folium.Map(MC, zoom_start=15, max_zoom=21, control_scale=True, tiles='cartodb positron')
folium.ClickForLatLng().add_to(m)

Expected behavior
expect it to copy to clipboard

Environment (please complete the following information):

# python.exe -c "import folium; print(folium.__version__)"
0.12.1.post1
# python.exe -c "import branca; print(branca.__version__)"
0.5.0
# python.exe -c "import sys; print(sys.version_info)"
sys.version_info(major=3, minor=10, micro=3, releaselevel='final', serial=0)

Other

Should be working from PR #1530.

@Conengmo
Copy link
Member

Conengmo commented Sep 7, 2022

Seems like that PR forgot to add the import to __init__.py, simple mistake. As a temporary workaround you can do from folium.features import ClickForLatLng.

In the meantime a PR to add it to the import and __all__ statement in __init__.py is welcome.

@Conengmo Conengmo added the bug An issue describing unexpected or malicious behaviour label Sep 7, 2022
@amrutharajashekar
Copy link
Contributor

Hi, can i work on this issue ?

@amrutharajashekar
Copy link
Contributor

Hi @Conengmo , I have submitted PR . ( #1627 )
Please let me know if any other changes are required.
Thanks!

ocefpaf pushed a commit to amrutharajashekar/folium that referenced this issue Oct 10, 2022
ocefpaf added a commit that referenced this issue Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected or malicious behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants