Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish docs test fails due to missing fiona dependency #2002

Closed
hansthen opened this issue Oct 6, 2024 · 2 comments
Closed

Publish docs test fails due to missing fiona dependency #2002

hansthen opened this issue Oct 6, 2024 · 2 comments

Comments

@hansthen
Copy link
Collaborator

hansthen commented Oct 6, 2024

Describe the bug
The automated tests are broken on main. There is an error in the publish docs test.

To Reproduce
See this dependabot commit dc84732.

Additional context
I tried to reproduce the issues locally. Locally, however, I do not have these errors. Perhaps someone can help write instructions on how to setup a sandboxed environment like in github to run these tests.

@prusswan
Copy link
Contributor

prusswan commented Oct 9, 2024

For the fiona import error, I suspect it has to do with geopandas dropping fiona as a dependency (now replaced with pyogrio) since 1.0.0 (see https:/geopandas/geopandas/blob/main/CHANGELOG.md#version-100-june-24-2024) - so it has to be imported if any of the workflow runs require it. Can't "prove" this as I could not find the logs for a previous successful run to compare against.

@hansthen hansthen changed the title Automated tests are failing without obvious reason Publish docs test fails due to missing fiona dependency Oct 19, 2024
@Conengmo
Copy link
Member

Fixed by #2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants