Refactor hardcoded JS CDN links to _protected variables #1312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
folium.py
exposes_default_js
and_default_css
at a high level. This is good, because you can override the CDN URL to point elsewhere. In my case, to point to a static assets folder.The plugins do not do this. This PR moves the URLs out of their respective
render()
methods to expose them in a similar way. This shouldn't change any existing behavior.Also, 98% of the changes are fixing
flake8
results. Sorry about that but I went by the contributing guideline.