Fix timestamped wms: don't add to control #1319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the example notebook for the
TimestampedWmsTileLayers
plugin causes a JS error. The layer control can't be initialized because theTimestampedWmsTileLayers
object itself does not exist in JS. Only theWmsTileLayer
objects, changed toL.timeDimension.layer.wms
objects, do.Fix this by not adding the
TimestampedWmsTileLayers
to layer control. This shouldn't be an option to users, since it doesn't work.This doesn't degrade the user experience, since the layers can still be switched on and off using the controls for the
WmsTileLayer
objects.Link to example notebook with fix applied: https://nbviewer.jupyter.org/github/conengmo/folium/blob/fix-timestamped-wms/examples/WmsTimeDimension.ipynb