-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TagFilterButton plugin #1343
Add TagFilterButton plugin #1343
Conversation
Added Examples and Tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! I updated the PR based on some improvements that came available later.
Link to example notebook: https://nbviewer.org/github/Waffleboy/folium/blob/tagfilterbutton/examples/TagFilterButton.ipynb
I removed the version for the plugin CDN link, so we'll always use the latest version.
I removed the onSelectionComplete
argument, since this refers to a Javascript function. This might confuse our Python users. Power users can still pass this through the kwargs
.
Let's merge this when the tests pass.
Thank you @Waffleboy for your PR! Sorry it took so long to get processed. It will be included in the next folium release, 0.14.0. |
A very useful (and even basic) feature for interactive maps is dynamic filtering of points.
There's a plugin for leaflet called Tag Filter Button which does precisely that, add a button that will dynamically filter the maps based on a feature.
Demo available here
Link to plugin
I have built the plugin for folium,
sans the test and examples. If this is chosen to be added, I'll add them as wellEDIT: Tests and examples added as well.