Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issues with Timeline and TreeLayerControl docs #1923

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

Conengmo
Copy link
Member

@Conengmo Conengmo commented Apr 4, 2024

We added two new plugin classes today, but there are some small issues with the docs:

  • they are missing in the plugins overview page
  • the TreeLayerControl example is not showing up because the map is not returned at the end
  • Sphinx is complaining about the docstrings of Timeline and TimelineSlider because the indentation is inconsistent.

@Conengmo Conengmo requested a review from hansthen April 5, 2024 07:44
@hansthen
Copy link
Collaborator

hansthen commented Apr 7, 2024

@Conengmo Thanks for fixing. I also discovered how I can review the generated documentation, so I hope it will not happen again in the future.

@hansthen hansthen merged commit 2e845e7 into python-visualization:main Apr 7, 2024
11 checks passed
@Conengmo Conengmo deleted the docs-missing-plugins branch June 14, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants