gh-74895: adjust tests to work on Solaris #104326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adjusts tests introduced in #2435 such that they work on platforms where
socket.getaddrinfo(None, port)
doesn't end with success; however, it does so whensocket.SOCK_STREAM
is present.I am aware only of Solaris that works this way, but it's still well within the standard (if not "more correct").
All other tests calling
getaddrinfo(None, ....)
includesocket.SOCK_STREAM
as well, and the addition doesn't change at all the thing the test is testing, so hopefully, this is acceptable.(can I reuse the original issue for an additional commit?)