bpo-38364: unwrap partialmethods just like we unwrap partials #16600

mjpieters · 2019-10-05T22:51:54Z

The inspect.isgeneratorfunction, inspect.iscoroutinefunction and inspect.isasyncgenfunction already unwrap functools.partial objects, this patch adds support for partialmethod objects as well.

https://bugs.python.org/issue38364

Lib/inspect.py

Lib/test/test_inspect.py

florimondmanca · 2019-12-21T17:47:26Z

Coincidently, this would also resolve another situation, i.e. when passing the partial of a method directly…

import functools, inspect

class Dog:
    async def abark(self): pass

inspect.iscoroutinefunction(dog.abark)  # True
inspect.iscoroutinefunction(functools.partial(dog.abark))  # False (should probably be True?)

This would be because the partial would be unwrapped (via the inner call to _unwrap_partial() here), yielding a method object that will be correctly handled by the method unwrapping.

jalaziz · 2022-03-05T22:30:46Z

This is also an issue for unittest mocking. patch will return MagicMock for partial async methods and not AsyncMock. In our case, the underlying code is using calling partial against a method, but as @florimondmanca pointed out, this PR should fix it.

kumaraditya303

There are merge conflicts.

bedevere-bot · 2022-12-30T11:38:25Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

mjpieters · 2022-12-30T14:39:47Z

I have made the requested changes; please review again.

bedevere-bot · 2022-12-30T14:39:51Z

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

Doc/library/inspect.rst

kumaraditya303 · 2022-12-31T06:32:40Z

Lib/functools.py

+ prev = None
+ while func is not prev:
+ prev = func
+ while isinstance(getattr(func, "_partialmethod", None), partialmethod):


Why getattr? What objects have _partialmethod?

partialmethod(...).__get__() can return a closure with _partialmethod pointing to the instance. This happens if the wrapped callable is not a descriptor, or if the descriptor returned itself again.

See the partialmethod._make_unbound_method() implementation.

getattr() is used because the attribute is optional, and you'd not want this to break even if the supplied object does have a _partialmethod attribute that is not actually a partialmethod instance.

bedevere-bot · 2022-12-31T06:32:58Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

mjpieters · 2022-12-31T11:34:45Z

I have made the requested changes; please review again.

bedevere-bot · 2022-12-31T11:34:49Z

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

The inspect.isgeneratorfunction, inspect.iscoroutinefunction and inspect.isasyncgenfunction already unwrap functools.partial objects, this patch adds support for partialmethod objects as well.

Since we'rs checking this attribute on arbitrary function-like objects, we should use the namespace reserved for core Python.

encukou · 2024-01-25T14:25:41Z

Hi! Just getting to this, sorry for the delay.
Since we're accessing _partialmethod on arbitrary objects, it would be best to rename it to __partialmethod__ -- make it part of the namespace reserved for Python.

I hope you don't mind me pushing directly to the PR.

All concerns from the review should be resolved now.

…on 3.13) The `_partialmethod` attribute of methods wrapped with `partialmethod()` was renamed to `__partialmethod__` in CPython 3.13: python/cpython#16600

…on 3.13) (#3272) The `_partialmethod` attribute of methods wrapped with `partialmethod()` was renamed to `__partialmethod__` in CPython 3.13: python/cpython#16600

Adding preliminary support for Python 3.13. The `_partialmethod` attribute of methods wrapped with `partialmethod()` was renamed to `__partialmethod__` in CPython 3.13: python/cpython#16600 Starting from Python 3.13, `frame.f_locals` is not `dict` anymore, but `FrameLocalsProxy`, that cannot be copied using `copy.copy()`. In Python 3.13 and later, it should be copied using a method `.copy()`. The new way of copying works the same as the old one for versions of Python prior to 3.13, according to the documentation (both copying methods produce a shallow copy). Since Python 3.13, `FrameLocalsProxy` skips items of `locals()` that have non-`str` keys; this is a CPython implementation detail, so we hence disable `test_non_string_variables` test on Python 3.13. See: https://peps.python.org/pep-0667/ python/cpython#118921 python/cpython#118923 https://docs.python.org/3.13/whatsnew/3.13.html#porting-to-python-3-13 https://docs.python.org/3/library/copy.html https:/python/cpython/blame/7b413952e817ae87bfda2ac85dd84d30a6ce743b/Objects/frameobject.c#L148 --------- Co-authored-by: Roman Inflianskas <[email protected]>

mjpieters requested a review from rhettinger as a code owner October 5, 2019 22:51

the-knights-who-say-ni added the CLA signed label Oct 5, 2019

bedevere-bot added the awaiting review label Oct 5, 2019

mjpieters force-pushed the bpo38364_partialmethod_inspect branch from 3e49547 to 4fecb83 Compare October 5, 2019 23:08

taleinat reviewed Nov 13, 2019

View reviewed changes

Lib/inspect.py Show resolved Hide resolved

taleinat reviewed Nov 13, 2019

View reviewed changes

Lib/test/test_inspect.py Outdated Show resolved Hide resolved

florimondmanca mentioned this pull request Dec 21, 2019

Rename 'next' to 'anext' on Response encode/httpx#676

Merged

thedrow mentioned this pull request Apr 6, 2020

Using partial functions in async stories incorrectly raises a StoryDefinitionError proofit404/stories#348

Closed

csabella requested review from 1st1 and encukou May 28, 2020 23:09

JayH5 mentioned this pull request Feb 2, 2021

Asynchronous classmethod handlers not recognized as coroutines if wrapped in functools.partial encode/starlette#1107

Closed

rhettinger removed their request for review May 3, 2022 06:34

ezio-melotti removed the CLA signed label Jul 13, 2022

mjpieters mannequin mentioned this pull request Jul 16, 2022

inspect.iscoroutinefunction / isgeneratorfunction / isasyncgenfunction can't handle partialmethod objects #82545

Open

kumaraditya303 requested changes Dec 30, 2022

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Dec 30, 2022

mjpieters force-pushed the bpo38364_partialmethod_inspect branch from 03ca24c to 84dd702 Compare December 30, 2022 14:14

bedevere-bot added awaiting change review and removed awaiting changes labels Dec 30, 2022

bedevere-bot requested a review from kumaraditya303 December 30, 2022 14:39

mjpieters force-pushed the bpo38364_partialmethod_inspect branch from 84dd702 to 35b8c19 Compare December 30, 2022 14:45

kumaraditya303 previously requested changes Dec 31, 2022

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting change review labels Dec 31, 2022

mjpieters force-pushed the bpo38364_partialmethod_inspect branch from 35b8c19 to 2fb40c2 Compare December 31, 2022 11:30

bedevere-bot added awaiting change review and removed awaiting changes labels Dec 31, 2022

bedevere-bot requested a review from kumaraditya303 December 31, 2022 11:34

mjpieters added 2 commits December 31, 2022 11:35

bpo-38364: unwrap partialmethods just like we unwrap partials

9cb267a

The inspect.isgeneratorfunction, inspect.iscoroutinefunction and inspect.isasyncgenfunction already unwrap functools.partial objects, this patch adds support for partialmethod objects as well.

📜🤖 Added by blurb_it.

243cb00

mjpieters force-pushed the bpo38364_partialmethod_inspect branch from 2fb40c2 to 243cb00 Compare December 31, 2022 11:35

kumaraditya303 removed their request for review May 30, 2023 12:31

encukou added 3 commits January 25, 2024 14:51

Merge in the main branch

2a9c535

Update versionchanged directives

d20e069

Rename _partialmethod to __partialmethod__

fa36941

Since we'rs checking this attribute on arbitrary function-like objects, we should use the namespace reserved for core Python.

encukou approved these changes Jan 29, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting change review labels Jan 29, 2024

encukou merged commit edb59d5 into python:main Feb 15, 2024
30 of 31 checks passed

bedevere-app bot removed the awaiting merge label Feb 15, 2024

mjpieters deleted the bpo38364_partialmethod_inspect branch February 20, 2024 12:57

rominf mentioned this pull request Jul 10, 2024

fix(utils): Handle partialmethod in qualname_from_function (CPython 3.13) getsentry/sentry-python#3272

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-38364: unwrap partialmethods just like we unwrap partials #16600

bpo-38364: unwrap partialmethods just like we unwrap partials #16600

mjpieters commented Oct 5, 2019 •

edited by bedevere-bot

Loading

florimondmanca commented Dec 21, 2019 •

edited

Loading

jalaziz commented Mar 5, 2022 •

edited

Loading

kumaraditya303 left a comment

bedevere-bot commented Dec 30, 2022

mjpieters commented Dec 30, 2022

bedevere-bot commented Dec 30, 2022

kumaraditya303 Dec 31, 2022

mjpieters Dec 31, 2022

bedevere-bot commented Dec 31, 2022

mjpieters commented Dec 31, 2022

bedevere-bot commented Dec 31, 2022

encukou commented Jan 25, 2024

bpo-38364: unwrap partialmethods just like we unwrap partials #16600

bpo-38364: unwrap partialmethods just like we unwrap partials #16600

Conversation

mjpieters commented Oct 5, 2019 • edited by bedevere-bot Loading

florimondmanca commented Dec 21, 2019 • edited Loading

jalaziz commented Mar 5, 2022 • edited Loading

kumaraditya303 left a comment

Choose a reason for hiding this comment

bedevere-bot commented Dec 30, 2022

mjpieters commented Dec 30, 2022

bedevere-bot commented Dec 30, 2022

kumaraditya303 Dec 31, 2022

Choose a reason for hiding this comment

mjpieters Dec 31, 2022

Choose a reason for hiding this comment

bedevere-bot commented Dec 31, 2022

mjpieters commented Dec 31, 2022

bedevere-bot commented Dec 31, 2022

encukou commented Jan 25, 2024

mjpieters commented Oct 5, 2019 •

edited by bedevere-bot

Loading

florimondmanca commented Dec 21, 2019 •

edited

Loading

jalaziz commented Mar 5, 2022 •

edited

Loading