Inconsistent results after 0.960 -> 0.971 migration

[sobolevn]

I am trying to migrate our huge code base from mypy 0.960 to 0.971, but odd things are happening.

For example, our CI fails with:

Run mypy --strict mypy_django_plugin
mypy_django_plugin/django/context.py:61: error: Unused "type: ignore" comment
mypy_django_plugin/django/context.py:62: error: Unused "type: ignore" comment
mypy_django_plugin/django/context.py:87: error: Untyped decorator makes function "model_modules" untyped
mypy_django_plugin/django/context.py:113: error: Returning Any from function declared to return "Optional[Type[Any]]"
mypy_django_plugin/django/context.py:233: error: Untyped decorator makes function "all_registered_model_classes" untyped
mypy_django_plugin/django/context.py:245: error: Untyped decorator makes function "all_registered_model_class_fullnames" untyped
mypy_django_plugin/django/context.py:251: error: Returning Any from function declared to return "str"
mypy_django_plugin/django/context.py:255: error: Returning Any from function declared to return "bool"
mypy_django_plugin/django/context.py:268: error: Returning Any from function declared to return "bool"
mypy_django_plugin/django/context.py:325: error: Unused "type: ignore" comment
mypy_django_plugin/django/context.py:335: error: Returning Any from function declared to return "Optional[Type[Any]]"

Link: https:/typeddjango/django-stubs/runs/7838309248?check_suite_focus=true

Locally it works as expected (python and mypy versions do match):

(.venv) ~/Documents/github/django-stubs  fix-ci ✗                                 
» python --version
Python 3.9.9

(.venv) ~/Documents/github/django-stubs  fix-ci ✗                                    
» mypy --version                  
mypy 0.971 (compiled: yes)

(.venv) ~/Documents/github/django-stubs  fix-ci ✗                                    
» mypy --strict mypy_django_plugin
Success: no issues found in 20 source files

Since we have quite a complex structure, it might be something on our side.
So, what do we do?

We store all stubs for django in django-stubs folder.
At the same level we have mypy_django_plugin that does fancy stuff with ORM / etc.
Our plugin imports a lot of things from django itself (settings, .setup(), etc).

Here's the tricky part: 0.960 recognised these imports and their types.
Right now my local setup with 0.971 does the same thing.

But, 0.971 in our CI does not see our stubs. So, all types are just Anys. This is unexpected!

Link: https:/typeddjango/django-stubs
Original PR: typeddjango/django-stubs#1108

[sobolevn]

Sorry, but I cannot find a reproducer.

[hauntsaninja]

Can you check if it is fixed with mypy master?
The most problematic change in 0.971 is #11143 , but I fixed known issues with that on master

[sobolevn]

I will take a look!

[hauntsaninja]

Oh the other thing is if you have editable installs in CI, make sure you're using setuptools < 64.

New setuptools breaks all IDE and static analysis tools. They knew of the issue and did it anyway 🤷

[sobolevn]

🤦

[intgr]

make sure you're using setuptools < 64.

New setuptools breaks all IDE and static analysis tools.

Any upstream discussions about this?

[AlexWaygood]

make sure you're using setuptools < 64.
New setuptools breaks all IDE and static analysis tools.

Any upstream discussions about this?

pypa/setuptools#3518 (and https://mail.python.org/archives/list/[email protected]/thread/IIVBPYDZR5T5BGPAWFVYS5ZPYDXGVHQN/#OSWHT5VSRGKPSPYD7PQWR2M4OCSL5WO3)

[erictraut]

Is there anything actionable in this bug report? Was there a repro identified? Did it turn out to be a problem with editable installs?