Fix union simplification performance regression #12519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11962 can generate large unions with many
Instance
types withlast_known_value
set. This caused our union simplification algorithmto be extremely slow, as it hit an O(n**2) code path.
We already had a fast code path for unions of regular literal types. This
generalizes it for unions containing
Instance
types with last knownvalues (which behave similarly to literals in a literal type context).
Also fix a union simplification bug that I encountered while writing tests
for this change.
Work on #12408.