Show attrs auto_detect incompleteness #16704
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test demonstrates that addition of dunder methods in attrs classes isn't quite complete. While the existing test demonstrates that it was working for classes defined with `init=False`, the `__attrs_init__` method wasn't generated in the same way when `__init__` was defined with `auto_detect=True` enabled (either explicitly, or by default). This auto-generated `__attrs_init__` has been enabled in Attrs as of version 21.1.0. Related to: python#10328 Ref: python-attrs/attrs#793 Ref: https://www.attrs.org/en/stable/changelog.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test demonstrates that addition of dunder methods in attrs classes isn't quite complete.
While the existing test demonstrated that the
__attrs_init__method was generated in classes defined withinit=False, it wasn't generated in the same way when__init__was defined withauto_detect=Trueenabled (either explicitly, or by default).The auto-generated
__attrs_init__has been enabled in Attrs since version 21.1.0.Related to: #10328
Ref: python-attrs/attrs#793
Ref: python-attrs/attrs#731
Ref: https://www.attrs.org/en/stable/changelog.html