Switch away from sys.exit(error_msg) in dmypy #5982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This kills a couple birds with one stone:
1. It fixes an interaction with the new run_dmypy api where
that message winds up as the return code instead of in
stderr.
This additionally fixes a type unsoundness/mypy_mypyc crash
caused by SystemExit.code being typed as int.
2. It allows us to standardize the irregular exit codes of dmypy
as 2.
Closed
gvanrossum
approved these changes
Nov 30, 2018
|
Should we document the exit codes? |
JukkaL
pushed a commit
that referenced
this pull request
Dec 3, 2018
This kills a couple birds with one stone:
1. It fixes an interaction with the new run_dmypy api where
that message winds up as the return code instead of in
stderr.
This additionally fixes a type unsoundness/mypy_mypyc crash
caused by SystemExit.code being typed as int.
2. It allows us to standardize the irregular exit codes of dmypy
as 2.
Opened #6003 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kills a couple birds with one stone:
that message winds up as the return code instead of in
stderr.
This additionally fixes a type unsoundness/mypy_mypyc crash
caused by SystemExit.code being typed as int.
as 2.