Update semanal_enum.py #8436
Update semanal_enum.py #8436
Conversation
Relaxed the checks for IntEnum arguments.
|
Thanks for the PR! It looks like some of the tests are broken -- can you fix them and add a few more? You can find more information on how to run and write tests at https:/python/mypy#tests. |
mypy/semanal_enum.py
Outdated
| @@ -107,7 +107,8 @@ def parse_enum_call_args(self, call: CallExpr, | |||
| if len(args) < 2: | |||
| return self.fail_enum_call_arg("Too few arguments for %s()" % class_name, call) | |||
| if len(args) > 2: | |||
| return self.fail_enum_call_arg("Too many arguments for %s()" % class_name, call) | |||
| if call.arg_kinds != [ARG_POS, ARG_POS, ARG_POS]: | |||
There was a problem hiding this comment.
This doesn't make much sense in the light of the next if condition: if this one passes the next one (on line 112) will still fail.
Numbers = IntEnum('Numbers', ['ZERO', 'ONE', 'TWO'], start=0)
Numbers = IntEnum('Numbers', ['ZERO', 'ONE', 'TWO'], start=0)
There was a problem hiding this comment.
Can you add tests for this change? E.g. we should confirm that mypy accepts expressions like Enum('foo', ['a', 'b', 'c'], qualname='bar') but not expressions like Enum('foo', ['a', 'b', 'c'], bad='bar')`, and other similar things.
My previous code review links to some docs on how to run and write tests for mypy.
mypy/semanal_enum.py
Outdated
| return self.fail_enum_call_arg("Too many arguments for %s()" % class_name, call) | ||
| if call.arg_kinds != [ARG_POS, ARG_POS]: | ||
| return self.fail_enum_call_arg("Unexpected arguments to %s()" % class_name, call) | ||
| if call.arg_kinds != [ARG_POS, ARG_POS, ARG_NAMED_OPT]: |
There was a problem hiding this comment.
Enum can accept up to four named arguments, not just one.
You should also try checking call.arg_names to make sure the arguments are what we expect.
There was a problem hiding this comment.
@Michael0x2a Sure! Will do it. Can I implement a switch statement to check for named arguments? Could you point to some coding practices that this repo generally follow?
Oh yes. Sorry. Co-Authored-By: Ethan Smith <[email protected]>
Relaxed the checks for IntEnum arguments.