Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 8: Allow both one and two spaces after period #3027

Merged
merged 2 commits into from
Feb 25, 2023
Merged

PEP 8: Allow both one and two spaces after period #3027

merged 2 commits into from
Feb 25, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 24, 2023 •
edited
Loading

Authored-by: Hugo van Kemenade [email protected]

@erlend-aasland erlend-aasland linked an issue Feb 24, 2023 that may be closed by this pull request
PEP 8: Consider removing "two spaces after period" #3024
Closed
@pradyunsg
Copy link
Member

FWIW you're missing a Co- for the commit body for GitHub to recognise it. Otherwise, git commit --amend --author [same text] would achieve making @hugovk the author and you could drop/change the commit body.

@erlend-aasland
Copy link
Contributor Author

FWIW you're missing a Co- for the commit body for GitHub to recognise it. Otherwise, git commit --amend --author [same text] would achieve making @hugovk the author and you could drop/change the commit body.

Right, I deliberately removed the Co-; I'll amend it and force-push.

JelleZijlstra
JelleZijlstra reviewed Feb 25, 2023
View reviewed changes
pep-0008.txt Outdated Show resolved Hide resolved
@gvanrossum
Copy link
Member

Can we make it self-referential? :-)

@hugovk @JelleZijlstra
Fix dangling hyphen
b13d652 
Co-authored-by: Jelle Zijlstra <[email protected]>
@hugovk
Copy link
Member

hugovk commented Feb 25, 2023

Re: #3024 (comment)

Do we also want to add something to say it "doesn't require consistency (not even within a paragraph)"?

Whilst editing this file, let's also remove the redundant Version and Last-Modified headers, and the Local Variables footer, as we've gradually been doing elsewhere.

@CAM-Gerlach CAM-Gerlach removed the request for review from ncoghlan February 25, 2023 08:28
@CAM-Gerlach
Copy link
Member

Do we also want to add something to say it "doesn't require consistency (not even within a paragraph)"?

Has that been enough of a problem (for code comments at least, which is what this mention is about and not the reST document that triggered this) that it's worth an explicit sentence stating so? Consistency is nice, just not required or worth changes to existing text that isn't already rewritten.

CAM-Gerlach
CAM-Gerlach approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland and @hugovk !

@JelleZijlstra JelleZijlstra merged commit 6d182da into python:main Feb 25, 2023
@erlend-aasland erlend-aasland deleted the less-churn branch February 25, 2023 12:45
carljm added a commit to carljm/peps that referenced this pull request Feb 25, 2023
@carljm
Merge branch 'main' into inlinecomp
4e07868 
* main:
  PEP 8: Allow both one and two spaces after period (python#3027)
  Meta: Further tweak PR template titles to get the right order (python#3001)
@encukou encukou mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@hugovk hugovk hugovk approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@warsaw warsaw Awaiting requested review from warsaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PEP 8: Consider removing "two spaces after period"
6 participants
@erlend-aasland @pradyunsg @gvanrossum @hugovk @CAM-Gerlach @JelleZijlstra