Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 604 (Unions with pipe character) tracker #4819

Closed
10 tasks done
srittau opened this issue Dec 14, 2020 · 13 comments · Fixed by #9686
Closed
10 tasks done

PEP 604 (Unions with pipe character) tracker #4819

srittau opened this issue Dec 14, 2020 · 13 comments · Fixed by #9686
Labels
project: feature tracker Tracks whether a typing feature can be used in typeshed stubs

Comments

@srittau srittau added the project: feature tracker Tracks whether a typing feature can be used in typeshed stubs label Jan 6, 2021
@srittau
Copy link
Collaborator Author

srittau commented Jan 6, 2021

@rchen152 @mrkmndz Do pytype/pyre support PEP 604? If not, would you mind me creating a ticket in the respective projects that we can reference from here?

@sproshev
Copy link
Contributor

sproshev commented Jan 6, 2021

Not yet supported by PyCharm https://youtrack.jetbrains.com/issue/PY-44974

@rchen152
Copy link
Collaborator

rchen152 commented Jan 7, 2021

This is not yet supported by pytype. Opened google/pytype#785.

@JelleZijlstra
Copy link
Member

Pyre already supports this. If I'm reading https://youtrack.jetbrains.com/issue/PY-44974 correctly, PyCharm already supports it enough for us to use it. That leaves only pytype.

@srittau
Copy link
Collaborator Author

srittau commented May 16, 2021

This is the #1 feature I'm waiting for. This means we can basically replace any Union and Optional in Python 3 typeshed with a more readable alternative.

@srittau
Copy link
Collaborator Author

srittau commented May 29, 2021

I think this is ready to be tested.

@srittau
Copy link
Collaborator Author

srittau commented Aug 24, 2021

Reopening for now due to a fix for python/mypy#10901 not being released, yet. This means, we can't use this in type aliases.

@srittau srittau reopened this Aug 24, 2021
@AlexWaygood
Copy link
Member

AlexWaygood commented Dec 16, 2021

I think mypy can now be ticked off, with the release of 0.920?

@JelleZijlstra
Copy link
Member

We should be done now :)

@srittau
Copy link
Collaborator Author

srittau commented Dec 16, 2021

We should replace remaining uses of Union and Optional.

@AlexWaygood
Copy link
Member

AlexWaygood commented Mar 22, 2022

I'm reopening this to track the remaining mypy bugs.

@AlexWaygood AlexWaygood reopened this Mar 22, 2022
@Avasam
Copy link
Collaborator

Avasam commented Dec 16, 2022

I'm reopening this to track the remaining mypy bugs.

What is/are the bug(s) left? Is it listed on mypy side?

@AlexWaygood
Copy link
Member

I'm reopening this to track the remaining mypy bugs.

What is/are the bug(s) left? Is it listed on mypy side?

None left now (to my knowledge)! All the significant bugs are now fixed on mypy master -- we're just waiting on a new release of mypy that includes the fixes. Then we can close this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: feature tracker Tracks whether a typing feature can be used in typeshed stubs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants