Add Arg() etc to mypy_extensions #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixolet
commented
Nov 11, 2016
| class DefaultArg(object): | ||
| def __init__(name: Optional[str]=..., | ||
| typ: Type[T]=..., | ||
| keyword_only: Optional[bool]=...) -> None: |
There was a problem hiding this comment.
Oops these actually shouldn't be optional. What I get for reviewing my own code.
ambv
force-pushed
the
master
branch
10 times, most recently
from
63ba0ab
to
7853c26
Compare
|
Closing, seems to be superseded by #793. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is relevant to python/typing#264 making
Callablemore flexible and able to represent more python functions.This adds stubs for
Arg,DefaultArg,StarArg, andKwArgtomypy_extensions.pyi. We should merge this before the relevant pull request tomypybut approve them as if they're one pull request.