Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate mixed optimizer to OSS #2573

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

saitcakmak
Copy link
Contributor

Differential Revision: D64349675

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 14, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64349675

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64349675

saitcakmak added a commit to saitcakmak/botorch that referenced this pull request Oct 14, 2024
Summary: Pull Request resolved: pytorch#2573

Differential Revision: D64349675
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (5053433) to head (343228e).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2573    +/-   ##
========================================
  Coverage   99.98%   99.98%            
========================================
  Files         195      196     +1     
  Lines       17122    17333   +211     
========================================
+ Hits        17119    17330   +211     
  Misses          3        3            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64349675

saitcakmak added a commit to saitcakmak/botorch that referenced this pull request Oct 15, 2024
Summary:
Pull Request resolved: pytorch#2573

Moves `optimize_acqf_mixed_alternating` to OSS BoTorch. This is an optimizer designed for mixed (low-cardinality) integer and continuous variables. It alternates between discrete and continuous optimization steps to optimize the acquisition function. The discrete step greedily searches over the integer variables, moving to the 1-Manhattan distance neighbor that offers the greatest improvement at each step. The continuous steps calls to `optimize_acqf` to optimize the continuous variables, while keeping the discrete dimensions fixed.

Differential Revision: D64349675
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64349675

saitcakmak added a commit to saitcakmak/botorch that referenced this pull request Oct 15, 2024
Summary:
Pull Request resolved: pytorch#2573

Moves `optimize_acqf_mixed_alternating` to OSS BoTorch. This is an optimizer designed for mixed (low-cardinality) integer and continuous variables. It alternates between discrete and continuous optimization steps to optimize the acquisition function. The discrete step greedily searches over the integer variables, moving to the 1-Manhattan distance neighbor that offers the greatest improvement at each step. The continuous steps calls to `optimize_acqf` to optimize the continuous variables, while keeping the discrete dimensions fixed.

Differential Revision: D64349675
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64349675

…oad the correct commit data.

Differential Revision: D64348157
saitcakmak added a commit to saitcakmak/botorch that referenced this pull request Oct 15, 2024
Summary:
Pull Request resolved: pytorch#2573

Moves `optimize_acqf_mixed_alternating` to OSS BoTorch. This is an optimizer designed for mixed (low-cardinality) integer and continuous variables. It alternates between discrete and continuous optimization steps to optimize the acquisition function. The discrete step greedily searches over the integer variables, moving to the 1-Manhattan distance neighbor that offers the greatest improvement at each step. The continuous steps calls to `optimize_acqf` to optimize the continuous variables, while keeping the discrete dimensions fixed.

Reviewed By: Balandat

Differential Revision: D64349675
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64349675

Summary:
Pull Request resolved: pytorch#2573

Moves `optimize_acqf_mixed_alternating` to OSS BoTorch. This is an optimizer designed for mixed (low-cardinality) integer and continuous variables. It alternates between discrete and continuous optimization steps to optimize the acquisition function. The discrete step greedily searches over the integer variables, moving to the 1-Manhattan distance neighbor that offers the greatest improvement at each step. The continuous steps calls to `optimize_acqf` to optimize the continuous variables, while keeping the discrete dimensions fixed.

Reviewed By: Balandat

Differential Revision: D64349675
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64349675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants