-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] More code-reuse across tests #1869
Comments
atalman
changed the title
Re-enable check_binary for all nightly builds
Enable check_binary for MacOS and Windows
Jun 17, 2024
I think title of this issue is somewhat misleading, as |
malfet
changed the title
Enable check_binary for MacOS and Windows
[BE] More code-reuse across tests
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Previous title:
Enable check_binary for MacOS and WindowsMacOS and Windows nightly builds are missing check_binary.sh step:
See reference issue: pytorch/pytorch#120995
Linux builds has check_binary: https:/pytorch/pytorch/actions/runs/9543726459/job/26305659019#step:17:308
However not macos or Windows.
For faster development. We can try to enable check binary running on Validation tests here:
https:/pytorch/builder/blob/main/.github/scripts/validate_binaries.sh#L54
When successful we can later move it our CI
The text was updated successfully, but these errors were encountered: