Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting Gemma checkpointing logic #1168

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

SalmanMohammadi
Copy link
Collaborator

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

#1062 #1122

Changelog

Reverting #1064, leaving Gemma checkpointing test in.

Test plan

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

Copy link

pytorch-bot bot commented Jul 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1168

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3e7e0ac with merge base 06a125e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2024
@ebsmothers ebsmothers self-requested a review July 12, 2024 13:52
@joecummings
Copy link
Contributor

@SalmanMohammadi Can you confirm that you can train a model for like 5 steps and then save and it works?

@ebsmothers
Copy link
Contributor

@joecummings I patched the changes on my end and ran tune run --nnodes 1 --nproc_per_node 4 lora_finetune_distributed --config gemma/7B_lora max_steps_per_epoch=5. Can confirm it now errors out at the PEFT weight conversion (i.e. this PR resolves the previous issue with lm_head.weight as it makes it past the saving of the model). So based on that I am gonna merge, we can work on a separate PR for the PEFT weight saving issue.

@ebsmothers ebsmothers merged commit 1af5135 into pytorch:main Jul 12, 2024
29 checks passed
maximegmd pushed a commit to maximegmd/torchtune that referenced this pull request Jul 13, 2024
pbontrager pushed a commit that referenced this pull request Jul 15, 2024
@SalmanMohammadi SalmanMohammadi deleted the revert_1064 branch July 20, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants