Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lora_dpo_distributed recipe #1609

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Fix lora_dpo_distributed recipe #1609

merged 3 commits into from
Sep 17, 2024

Conversation

SLR722
Copy link
Contributor

@SLR722 SLR722 commented Sep 17, 2024

missing several LoRA related attributes

test with CUDA_VISIBLE_DEVICES=1,3 tune run --nproc_per_node 2 lora_dpo_distributed --config llama2/7B_lora_dpo max_steps_per_epoch=10

Copy link

pytorch-bot bot commented Sep 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1609

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cc4ceac with merge base 6b55c1d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2024
@RdoubleA RdoubleA merged commit 03c087f into pytorch:main Sep 17, 2024
17 checks passed
ebsmothers pushed a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants