Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run CI on forked repos #1681

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Sep 25, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

https:/janeyx99/torchtune/actions/runs/11004925000 Every night I get 2 spammy emails telling me my CI doesn't work, but like duh it doesn't work on my fork. Thanks @felipemello1 for explaining the problem, and here's the PR to gate CI behind this repo!

FYI this experience is not very fun for OSS contributors because CI will run on their forks, and they will either get errors, or compute will be wasted on running the periodic CI.

Changelog

What are the changes made in this PR?

  • Mentioned above

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented Sep 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1681

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b2d1a37 with merge base 7eb362c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2024
@felipemello1
Copy link
Contributor

Thanks, @janeyx99! You are a champ! Do you know the best way to test it? Just let the CI run?

@janeyx99
Copy link
Contributor Author

@felipemello1 Yes, nothing should be changed in torchtune CI (and I should stop getting emails).

Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why I was getting all those emails?! Seriously though.. thank you for fixing this

@@ -82,7 +83,7 @@ jobs:
upload:
runs-on: ubuntu-latest
needs: build_docs
if: github.repository == 'pytorch/torchtune' && github.event_name == 'push' && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v'))
if: github.repository_owner == 'pytorch' && github.event_name == 'push' && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about this one in particular.. why isn't github.repository == 'pytorch/torchtune' sufficient? My assumption is that forks would have a separate repository name, is that not the case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it totally was sufficient, i just changed it for consistency so someone looking can see that it’s the same across the workflows

@janeyx99 janeyx99 merged commit b846407 into pytorch:main Sep 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants