Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[In Progress] FSDP2 + NF4Tensor #651

Closed
wants to merge 1 commit into from

Conversation

weifengpy
Copy link
Contributor

@weifengpy weifengpy commented Apr 4, 2024

Stack from ghstack (oldest at bottom):

pytorch part: ghstack checkout pytorch/pytorch#119378
torhAO part: pytorch/ao#118
torchtune part: this PR

tune run --nnodes 1 --nproc_per_node 2 lora_finetune_fsdp2.py --config configs/llama2/7B_qlora_single_device.yaml max_steps_per_epoch=10

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/651

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit 6fed0a5 with merge base 8183b42 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

weifengpy added a commit that referenced this pull request Apr 4, 2024
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 5ad2393c7ca87df3283ff319d6362f0d2b5e606a
Pull Request resolved: #651
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2024
@weifengpy weifengpy marked this pull request as draft April 4, 2024 01:01
@weifengpy weifengpy changed the title proof of concept for FSDP2 + NF4Tensor [In Progress] FSDP2 + NF4Tensor Apr 4, 2024
@weifengpy weifengpy closed this May 1, 2024
@weifengpy
Copy link
Contributor Author

propose new PR: #909

@joecummings joecummings deleted the gh/weifengpy/1/head branch May 14, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants