Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Quickfixes on W&B #772

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Some Quickfixes on W&B #772

merged 1 commit into from
Apr 16, 2024

Conversation

tcapelle
Copy link
Contributor

  • Englobe the OmegaConf saving on the try block, to avoid crashing at any cost.
  • Add repo telemetry

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/772

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f19d4d6 with merge base dde16be (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
joecummings
joecummings reviewed Apr 16, 2024
View reviewed changes
torchtune/utils/metric_logging.py
project=project,
entity=entity,
group=group,
reinit=True,
resume="allow",
**kwargs,
)
run._label(repo="torchtune")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this a little more? What does the repo kwarg enable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We get telemetry on the repo usage. We already do this by grabbing the git repo used to train but if people rename it or fork it can mess up the identification. We can share this data with you guys to see adoption.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice, it is just one extra key in: https://wandb.ai/capecape/torchtune/runs/ynahtfyw/files/config.yaml
the key 9

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the explanation! (We would love to see adoption numbers soon :) )

joecummings
joecummings approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quickfixes

@joecummings joecummings merged commit e9e082e into pytorch:main Apr 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecummings joecummings joecummings approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcapelle @joecummings @facebook-github-bot