Added --output-dir-use-symlinks for tune download with default as auto #816
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/816
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 41dc36f with merge base 41341fd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @apthagowda97! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
torchtune/_cli/download.py
Outdated
| "--output-dir-use-symlinks", | ||
| type=str, | ||
| required=False, | ||
| default="False", |
There was a problem hiding this comment.
Can we default this to 'auto' to mimic the behavior from before?
There was a problem hiding this comment.
If we are downloading model to --output-dir folder. Why simply store that model in .cache ?
By selecting "auto" as default .. deletion of the model wont work properly and we need to run huggingface-cli delete-cache to delete.
Let me know your thoughts?
There was a problem hiding this comment.
I understand your point and we can add a note about that in the documentation somewhere, but I'd like to keep the defaults the same for args that map 1:1 to Hugging Face CLI commands.
|
|
||
| # Raise if local_dir_use_symlinks is invalid | ||
| output_dir_use_symlinks: Union[Literal["auto"], bool] | ||
| use_symlinks_lowercase = args.output_dir_use_symlinks.lower() |
There was a problem hiding this comment.
argparse can actually handle all of this logic within the add_argument method.
e.g.
self._parser.add_argument(
...,
choices = ["true", "false", "auto"],
)
There was a problem hiding this comment.
This wont work because coz.. true and false should be of type Boolean.
Ref: https:/huggingface/huggingface_hub/blob/main/src/huggingface_hub/commands/download.py
There was a problem hiding this comment.
It looks like they do the same thing as we do here: https:/huggingface/huggingface_hub/blob/54e4f76594d2d8338ddccab566a9750cfe4da1bd/src/huggingface_hub/commands/download.py#L96. Just needs to be "True" and "False", rather than lowercase.
There was a problem hiding this comment.
But here the they convert to Boolean, I just used there logic https:/huggingface/huggingface_hub/blob/54e4f76594d2d8338ddccab566a9750cfe4da1bd/src/huggingface_hub/commands/download.py#L137
There was a problem hiding this comment.
Ahh I missed that in the code, thanks for pointing it out. It's so gross, but seems like the best way to go forward.
Thanks for all your work on this @apthagowda97, I'll go ahead and merge!
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
apthagowda97
changed the title
Context
tune downloadwith default asauto.Changelog
Test plan