Fix import error from quantization before PyTorch 2.3 #920
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/920
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ef82676 with merge base f5b8eaf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Summary: pytorch#884 introduced a quantizer that was not available before PyTorch 2.3, causing import errors for users using an earlier version. In torchao, we gate the import by PyTorch version. We can do the same here.
andrewor14
force-pushed
the
fix-import-error-2.3
branch
from
f3099a8
to
ef82676
Compare
joecummings
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#884 introduced a quantizer that was not available before PyTorch 2.3, causing import errors for users using an earlier version. In torchao, we gate the import by PyTorch version. We can do the same here.