Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HLO instructions as per issue #7188 #7317

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Arshi81099
Copy link

I have updated stablehlo.md file

@qihqi
Copy link
Collaborator

qihqi commented Jun 25, 2024

Hi, thanks for contributing. Would you describe what issues with the current doc you are trying to fix? Looks like the formatting is off with the new change. Thanks!

@lsy323
Copy link
Collaborator

lsy323 commented Jun 25, 2024

@Arshi81099 Thanks for the PR, however, I found you removed all of the format in .md files, I guess you removed those accidentally. You can preview the markdown file in VS Code or other editors.

@Arshi81099
Copy link
Author

Arshi81099 commented Jun 26, 2024

Hi, thanks for contributing. Would you describe what issues with the current doc you are trying to fix? Looks like the formatting is off with the new change. Thanks!

Hi @qihqi ,
I have made the following changes to the original document:

  1. Improved code consistency and formatting for better readability.
  2. Added missing explanations for certain steps to enhance clarity.
  3. Separated commands for saving StableHLO bytecodes and converting them for TensorFlow Serving into distinct sections.
  4. Provided context about the prototype nature of the feature and potential future changes.
  5. Ensured all necessary imports and initializations are included in the code examples.

Thank you

@Arshi81099
Copy link
Author

Arshi81099 commented Jun 26, 2024

@Arshi81099 Thanks for the PR, however, I found you removed all of the format in .md files, I guess you removed those accidentally. You can preview the markdown file in VS Code or other editors.

Hi @lsy323, thank you so much!!
I have updated and raised PR

@lsy323
Copy link
Collaborator

lsy323 commented Aug 13, 2024

The code is not correctly formatted, please review and correct it, thanks

@Arshi81099
Copy link
Author

The code is not correctly formatted, please review and correct it, thanks

Hi @lsy323, Thank you for pointing that out. I've reviewed and corrected the code formatting. Please find the updated version below. Let me know if there are any further adjustments needed.

@lsy323
Copy link
Collaborator

lsy323 commented Aug 16, 2024

The code is not correctly formatted, please review and correct it, thanks

Hi @lsy323, Thank you for pointing that out. I've reviewed and corrected the code formatting. Please find the updated version below. Let me know if there are any further adjustments needed.

Hmm I still see it's not formatted, could you please check again, thanks

image

@Arshi81099
Copy link
Author

Hi @lsy323 , hope it's formatted now.
Please find the updated version below. Let me know if there are any further adjustments needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants