-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos in calibration coefficients #66
Comments
👍 Nice catches! And very tedious work... Thanks! |
@abhaydd any comments? |
Agree with @sfinkens Nice catches and fixes :) Thanks a lot @carloshorn and @mraspaud |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have written a script to convert PATMOS-x coefficients from tar balls as provided on their official website to PyGAC json files as introduced in #58.
After testing the script with the coefficient version which should correspond to the current PyGAC coefficients, I noticed some typos which I would like to correct with a PR.
pygac/pygac/calibration.py
Lines 56 to 57 in 2d7fbaf
Last value should be 1.224 instead of -0.016 according to metopa coeffs
pygac/pygac/calibration.py
Line 214 in 2d7fbaf
Second value should be 0.0005882 instead of 0.0005885 according to noaa10 coeffs
pygac/pygac/calibration.py
Line 207 in 2d7fbaf
Second value should be -7.29 instead of -7.27 according to noaa10 coeffs
pygac/pygac/calibration.py
Line 278 in 2d7fbaf
Last value should be -0.022171 (negative) (beside the division by the slope, see channel 4 BT to radiance conversion #57 ) according to noaa14 coeffs
pygac/pygac/calibration.py
Line 352 in 2d7fbaf
First value should be 1.7002941 instead of 1.70002941 (too many zeros) (beside the division by the slope, see channel 4 BT to radiance conversion #57 ) according to noaa17 coeffs
pygac/pygac/calibration.py
Lines 101 to 102 in 2d7fbaf
The first value in each array should be 0.113 instead of 0.133 according to noaa6 coeffs
pygac/pygac/calibration.py
Lines 109 to 113 in 2d7fbaf
The second row, first column in array should be 276.659 instead of 277.659 according to noaa6 coeffs
pygac/pygac/calibration.py
Line 162 in 2d7fbaf
First value should be 1.7002941 instead of 1.70002941 (too many zeros) (beside the division by the slope, see channel 4 BT to radiance conversion #57 ) according to noaa8 coeffs
pygac/pygac/calibration.py
Line 92 in 2d7fbaf
Second and third value should be 913.05397 instead of 913.0537 according to tirosn coeffs
pygac/pygac/calibration.py
Lines 86 to 90 in 2d7fbaf
The second row, first column in array should be 276.659 instead of 277.659 according to tirosn coeffs
I will create a PR, once #58 is merged into master, because I got these differences when comparing the current json files with the one that I produced from the tar ball on the PATMOS-x website.
The text was updated successfully, but these errors were encountered: