Cleanup RSR and LUT download functions for clearer usage #154
Conversation
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 83.79% 87.94% +4.15%
==========================================
Files 23 23
Lines 2394 2473 +79
==========================================
+ Hits 2006 2175 +169
+ Misses 388 298 -90
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -283,8 +296,7 @@ def download_rsr(**kwargs): | |||
|
|
|||
| config = get_config() | |||
| local_rsr_dir = config.get('rsr_dir') | |||
| dest_dir = kwargs.get('dest_dir', local_rsr_dir) | |||
| dry_run = kwargs.get('dry_run', False) | |||
| dest_dir = dest_dir or local_rsr_dir | |||
| else: | ||
| aerosol_types = HTTPS_RAYLEIGH_LUTS.keys() | ||
|
|
||
| aerosol_types = _get_aerosol_types(aerosol_types, aerosol_type) |
There was a problem hiding this comment.
Really nice with the improved/refactored np2str tests also, thanks.
I wonder if we could use the responses module here?
https://pypi.org/project/responses/
I used it a tiny bit in another project recently, after suggestion by @mraspaud
I don't want to add to your long To-Do-List, so if you have done some system-testing verifying that the download functions still work the same, we could also leave it here and add an issue to fix better test coverage of the download functionality?
|
@adybbroe I think I'll add more involved tests still. So far what I added last night was just a placeholder. I'll look at the responses package. If you're OK with it being added then I'm ok with that. I've never used it and I know I did some annoying mocking stuff in Satpy to get something like that working so I'm glad a third-party solution exists. |
|
|
@adybbroe Ok, I think this is ready for re-review. We'll have to wait for the tests to know if code coverage was increased a lot but I'm guessing it is based on my local tests. |
Co-authored-by: Adam Dybbroe <[email protected]>
Co-authored-by: Adam Dybbroe <[email protected]>
I was updating some code I have that uses the download functions in pyspectral, but started to get frustrated by lack of docstrings or clear keyword arguments. This PR cleans up docstrings and keyword arguments as well as simplifying some of the logic. It includes one deprecation for the aerosol_type versus aerosol_types keyword argument to be more consistent with the
check_and_downloadfunctions.pytest pyspectralflake8 pyspectral