Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AVHRR example #20

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Update AVHRR example #20

merged 2 commits into from
Feb 10, 2020

Conversation

sfinkens
Copy link
Member

Add introduction, update reader name, explain usage of reader_kwargs, add example with individual channels.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@sfinkens sfinkens marked this pull request as ready for review November 26, 2019 16:21
@sfinkens sfinkens self-assigned this Nov 26, 2019
pnuu
pnuu approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mraspaud
mraspaud reviewed Nov 27, 2019
View reviewed changes
satpy/avhrr_l1b_gaclac.ipynb
@@ -0,0 +1,261 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to pygac github actually points to a specific PR, is that then way you want it ?


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. A couple of people were asking me about reading LAC data with pygac. But since there hasn't been much progress on the LAC reader (no offence :)) I wanted to encourage users to contribute.

satpy/avhrr_l1b_gaclac.ipynb
@@ -0,0 +1,261 @@
{
Copy link
Member

@mraspaud mraspaud Nov 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be mention that some noaa 16 tles are provided on github?


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, added a link!

@mraspaud Review Notebook App
Copy link
Member

Also, should we have a link to this example in the pygac documentation or readme ?

@sfinkens Review Notebook App
Copy link
Member Author

Another good idea, will do!

@sfinkens sfinkens mentioned this pull request Nov 27, 2019
Merged
@mraspaud
Copy link
Member

The LAC data reading is now available from pygac, but we can make another PR for this.

@mraspaud mraspaud merged commit f0e3860 into pytroll:master Feb 10, 2020
djhoese pushed a commit that referenced this pull request Aug 17, 2020
@mraspaud
Merge pull request #20 from sfinkens/feature-update-avhrr-example
1d8f6fd 
Update AVHRR example
djhoese pushed a commit that referenced this pull request Aug 17, 2020
@mraspaud
Merge pull request #20 from sfinkens/feature-update-avhrr-example
bf836ea 
Update AVHRR example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraspaud mraspaud mraspaud left review comments

@pnuu pnuu pnuu approved these changes

@adybbroe adybbroe Awaiting requested review from adybbroe

Assignees

@sfinkens sfinkens

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfinkens @mraspaud @pnuu