-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the reader for the fci L1C Africa files #2778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Clement for this nice work! I have left some comments and hints in the code.
Please also expand in the Filehandler docstring the fact that we support also the African data now, with link to the AfricaPUG.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2778 +/- ##
==========================================
+ Coverage 95.94% 95.95% +0.01%
==========================================
Files 379 379
Lines 53673 53958 +285
==========================================
+ Hits 51494 51774 +280
- Misses 2179 2184 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 9205754552Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
a general comment about the
if this works it would reduce the number of lines in the file by 400+ lines (already 2500 lines long!!) and would be easier to read and maintain. @ClementLaplace can you make a quick test and see if it works? if yes, please modify the PR accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work @ClementLaplace ! a few comments/questions for improved(?) readability and maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last nitpicks and editorial comments. thanks clement for taking care of this feature!
…_nc.yaml file, erase _ that is in front for some constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…uture change in the file name for AF data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, especially with refactoring the tests! They are still quite intricate, but it's getting better :) some quick fixes mentioned inline, but after that it's good to merge IMO
I have added the possibility to read the data for AFRICA files related to the FCI instrument for the L1C level.
AUTHORS.md
if not there already