Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.9 #2936

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Drop python 3.9 #2936

merged 2 commits into from
Oct 18, 2024

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Oct 17, 2024

This PR drops support for python 3.9, as deemed reasonable in #2741. This superseeds #2741 which was difficult to merge with main.
Also, we added an experimental build for python 3.13.

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Oct 17, 2024
@mraspaud mraspaud self-assigned this Oct 17, 2024
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (5634073) to head (f9dccad).
Report is 77 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2936    +/-   ##
========================================
  Coverage   96.08%   96.09%            
========================================
  Files         375      377     +2     
  Lines       54615    55075   +460     
========================================
+ Hits        52478    52925   +447     
- Misses       2137     2150    +13     
Flag Coverage Δ
behaviourtests 3.95% <ø> (-0.04%) ⬇️
unittests 96.19% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mraspaud
Copy link
Member Author

hmm, looks like the 3.13 experimental was a bad idea...

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11384578870

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.01%) to 96.202%

Files with Coverage Reduction New Missed Lines %
satpy/readers/file_handlers.py 1 97.4%
satpy/readers/sgli_l1b.py 1 95.17%
satpy/readers/xmlformat.py 1 88.79%
satpy/tests/reader_tests/test_ahi_hsd.py 1 99.34%
satpy/readers/pmw_channels_definitions.py 2 96.41%
Totals Coverage Status
Change from base Build 11381112172: -0.01%
Covered Lines: 53169
Relevant Lines: 55268

💛 - Coveralls

@djhoese
Copy link
Member

djhoese commented Oct 17, 2024

Were all the FCI/decomp requirements/requests related to dropping Python 3.9 resolved?

@mraspaud
Copy link
Member Author

Yes I think so

@mraspaud
Copy link
Member Author

The last comment on #2741 confirms it.

@pnuu pnuu merged commit b3394c7 into pytroll:main Oct 18, 2024
18 checks passed
@mraspaud mraspaud deleted the drop-py39 branch October 18, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants