Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cache): handle get_from_cache=None and ensure directory exists #544

Merged
merged 1 commit into from
Jul 4, 2024
Merged

fix(cache): handle get_from_cache=None and ensure directory exists #544

merged 1 commit into from
Jul 4, 2024

Conversation

dylanpulver
Copy link
Collaborator

  • Added file lock handling for get_from_cache=None
  • Updated to filelock==3.12.2
  • Ensured the cache directory exists
  • Updated write_cache and corresponding tests

This was referenced Jul 3, 2024
Closed
Open
yeisonvargasf
yeisonvargasf approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@yeisonvargasf yeisonvargasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yeisonvargasf yeisonvargasf merged commit b2f0a16 into main Jul 4, 2024
12 checks passed
dylanpulver added a commit that referenced this pull request Jul 4, 2024
@dylanpulver
fix(cache): handle get_from_cache=None and ensure directory exists (#544
3048143 
)

Signed-off-by: Dylan Pulver <[email protected]>
dylanpulver added a commit that referenced this pull request Jul 9, 2024
@dylanpulver
parent f15d790
a76bc42 
author Dylan Pulver <[email protected]> 1719603852 -0400
committer Dylan Pulver <[email protected]> 1720552637 -0400
gpgsig -----BEGIN PGP SIGNATURE-----

 iHUEABYKAB0WIQQVa+zaLSZxm3/LxmooEm7VNVc3KwUCZo2MvQAKCRAoEm7VNVc3
 Kw3EAP0acAlkZ3XYxvP5P8H4rAx4XXhAOp1Sv7OnQu/nbuPhIgEAitluAgNBdtDU
 jrt9pNq7Y1I76KOuKS+8VRewmuYJUQI=
 =bYzZ
 -----END PGP SIGNATURE-----

fix(debug): fix --debug flag and associated tests

- Fix --debug flag functionality
- Add tests using runner.invoke
- Fix and modify fetch_database function
- Ensure all tests pass with appropriate patchings

Fix --debug flag

remove duplicate block

undo linting

remove test_debug file

modify fetch_database

fix(cache): handle get_from_cache=None and ensure directory exists (#544)

Signed-off-by: Dylan Pulver <[email protected]>

chore: release 3.2.4 (#545)

refactor: Jeff refactor suggestions

Switch to use main() function

refactor: adjust to cli() and cli_internal()

refactor: fix click group to be on new cli() func

fix: fix function order

fix: fix function order

fix: fix tests for debug flag changes

remove uneeded files

don't call dummy funcs

fix(debug): fix --debug flag and associated tests

- Fix --debug flag functionality
- Add tests using runner.invoke
- Fix and modify fetch_database function
- Ensure all tests pass with appropriate patchings

Fix --debug flag

undo linting
@dylanpulver dylanpulver mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeisonvargasf yeisonvargasf yeisonvargasf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanpulver @yeisonvargasf